Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B aws appflow flow trigger config #26240

Merged
merged 6 commits into from Aug 11, 2022
Merged

B aws appflow flow trigger config #26240

merged 6 commits into from Aug 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25172

Output from acceptance testing:
(run from internal/service/appflow -- one line added to the testAccFlowConfig_basic test)

$ go test -v flow_test.go
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_tags
=== CONT  TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_disappears
    flow_test.go:174: Acceptance tests skipped unless env 'TF_ACC' set
--- SKIP: TestAccAppFlowFlow_disappears (0.00s)
=== CONT  TestAccAppFlowFlow_update
=== CONT  TestAccAppFlowFlow_basic
    flow_test.go:26: Acceptance tests skipped unless env 'TF_ACC' set
--- SKIP: TestAccAppFlowFlow_basic (0.00s)
=== CONT  TestAccAppFlowFlow_TaskProperties
    flow_test.go:101: Acceptance tests skipped unless env 'TF_ACC' set
=== CONT  TestAccAppFlowFlow_update
    flow_test.go:71: Acceptance tests skipped unless env 'TF_ACC' set
--- SKIP: TestAccAppFlowFlow_TaskProperties (0.00s)
--- SKIP: TestAccAppFlowFlow_update (0.00s)
=== CONT  TestAccAppFlowFlow_tags
    flow_test.go:127: Acceptance tests skipped unless env 'TF_ACC' set
--- SKIP: TestAccAppFlowFlow_tags (0.00s)
PASS
ok      command-line-arguments  8.204s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/appflow Issues and PRs that pertain to the appflow service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 11, 2022
@ghost ghost mentioned this pull request Aug 11, 2022
Closed
github-actions[bot]
github-actions bot reviewed Aug 11, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @johnr-odusa 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 11, 2022
ewbankkit
ewbankkit approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppFlowFlow_basic' PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_basic -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_basic
--- PASS: TestAccAppFlowFlow_basic (27.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	32.057s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 11, 2022
@ewbankkit
Copy link
Contributor

@johnr-odusa Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a5488d9 into hashicorp:main Aug 11, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 11, 2022
@ghost
Copy link
Author

ghost commented Aug 11, 2022

Thanks so much!

@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.

aws_appflow_flow error setting trigger_config
1 participant
@ewbankkit